add api.nasa.gov to the startWebRequest whitelist #16444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Awesome!
…On Jul 17, 2017 9:18 AM, "David Bailey" ***@***.***> wrote:
requested by https://codeorg.zendesk.com/agent/tickets/104253
response type appears to be json based on the example queries at
https://api.nasa.gov/api.html#earth .
------------------------------
You can view, comment on, or merge this pull request online at:
#16444
Commit Summary
- add api.nasa.gov to the startWebRequest whitelist
File Changes
- *M* dashboard/app/controllers/xhr_proxy_controller.rb
<https://github.com/code-dot-org/code-dot-org/pull/16444/files#diff-0>
(1)
Patch Links:
- https://github.com/code-dot-org/code-dot-org/pull/16444.patch
- https://github.com/code-dot-org/code-dot-org/pull/16444.diff
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#16444>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ABinke4N7AHEDZJMn2SB0XiCjB2rdUK7ks5sO4fygaJpZM4OaKwL>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requested by https://codeorg.zendesk.com/agent/tickets/104253
response type appears to be json based on the example queries at https://api.nasa.gov/api.html#earth .