Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n sync In & Up 07/18 #16470

Merged
merged 6 commits into from Jul 20, 2017
Merged

I18n sync In & Up 07/18 #16470

merged 6 commits into from Jul 20, 2017

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Jul 18, 2017

No description provided.

@Hamms Hamms requested a review from tanyaparker July 18, 2017 19:36
@Hamms Hamms added the i18n label Jul 18, 2017
@@ -188,3 +188,6 @@ en:
courseF_unplugged_powerOfWords:
title: Unplugged Activity
desc: Today you will learn about what to do if someone is being mean online.
deeper learning description:
title: ''
desc: 'translation missing: en-US.data.unplugged.desc'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this mistake was caused by a content editor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely came from levelbuilder here: 92b917d

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think it's worth worrying about?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah. This looks like a thing that was created by accident and is probably not used. Let's just leave it, hide in Crowdin, and eventually we'll clean up stuff like this. I'm having Fikayo work on i18n stuff so we may actually get to doing clean up this summer!

@@ -2788,7 +2788,13 @@ en:
coursef_powerofwords:
description here: description here
title: title
csd deeper learning timeline:
Deeper Learning Submissions Deadlines: Deeper Learning Submissions Deadlines
description here: description here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also seems weird but looks like has been a problem for a while. Many of these titles and descriptions aren't real. But then again we hide all csd and csp in Crowdin. So doesn't matter because translators won't see it, but will make your scripts run longer the bigger these files get.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'll make a note to investigate this

@Hamms Hamms merged commit ca338a7 into staging Jul 20, 2017
@Hamms Hamms deleted the i18n-sync-in-up-07-18 branch July 20, 2017 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants