Progress stage extras #16565
Merged
Progress stage extras #16565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjvanminnen
commented
Jul 24, 2017
| title: "Stage Extras", | ||
| url: script_stage_stage_extras_url(script.name, stage_position: absolute_position), | ||
| }, | ||
| stage_extras_level_url: script_stage_stage_extras_url(script.name, stage_position: absolute_position), |
There was a problem hiding this comment.
By sending down a fake level object for stage extras, I was worried it would be easy at a future point to change the shape of Level.summarize, and not realize we needed to update this too. Given that the rest of this info is hardcoded, I decide to instead just pass the client a url, and let it own figuring out what to with it.
Bjvanminnen
force-pushed
the
progressStageExtras
branch
from
5fdbb91
to
45c3934
Compare
|
+cc @ryansloan |
Hamms
approved these changes
Jul 25, 2017
| title: "Stage Extras", | ||
| url: script_stage_stage_extras_url(script.name, stage_position: absolute_position), | ||
| }, | ||
| stage_extras_level_url: script_stage_stage_extras_url(script.name, stage_position: absolute_position), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of the work in https://github.com/code-dot-org/code-dot-org/pull/16270/files, but is compatible with our new progress bubbles. To enable, you need two experiments on:
progressBubblesandstageExtrasIt takes a slightly different design in that the the server is entirely responsible for determining whether or not stageExtras are enabled for this user/section. The client can then assume that if it has been given stageExtras info, it can/should show it.
Stage extras when we're not on stage extras level
Stage extras when we are on stage extras level
TODO: tests!