Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't disable procedure autopopulate in edit mode #16581

Merged
merged 1 commit into from Jul 31, 2017
Merged

don't disable procedure autopopulate in edit mode #16581

merged 1 commit into from Jul 31, 2017

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Jul 24, 2017

.. or else when editing the toolbox, you aren't presented with blocks with which to override autopopulation in the first place 馃檭

@Hamms Hamms requested a review from joshlory July 24, 2017 22:50
@Hamms
Copy link
Contributor Author

Hamms commented Jul 24, 2017

fyi @kiki-lee

joshlory
joshlory approved these changes Jul 26, 2017
View reviewed changes
Copy link
Contributor

@joshlory joshlory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still be tempted to make this not configurable 馃槃. But it sounds like that would involve a lot of cleanup work in old levels...

LGTM.

@Hamms Hamms merged commit 3a92fa7 into staging Jul 31, 2017
@Hamms Hamms deleted the dont-disable-autopopulate-in-edit-mode branch August 22, 2017 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlory joshlory joshlory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @joshlory