New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home: aesthetic improvements #16611
Home: aesthetic improvements #16611
Conversation
apps/src/templates/Notification.jsx
Outdated
@@ -139,14 +143,18 @@ const Notification = React.createClass({ | |||
bullhorn: 'bullhorn' | |||
}; | |||
|
|||
const buttonStyle = type !== "course" ? styles.button : [styles.button, styles.courseButton]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always prefer ternaries to use the positive when possible:
const buttonStyle = type === "course" ? [styles.button, styles.courseButton] : styles.button;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think we could/should use NotificationType.course
instead of course
here and elsewhere in this file.
@@ -46,6 +45,10 @@ const styles = { | |||
borderWidth: 1, | |||
borderColor: 'red' | |||
}, | |||
actionBox: { | |||
float: 'right', | |||
marginRight: 21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
21 seems pretty specific. Worth a comment on how we got to this number?
/> | ||
<div> | ||
<Notification | ||
type="course" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NotificationType.course
|
without sections:
with sections: