Console error info

[Bjvanminnen]

This attempts to add some better login for when we hit console errors.

(1) It includes the name of the test where the error is thrown, for example if I have

it('has an error', () => {
  console.error('brents');
});

I get

FAILED TESTS:
  unit tests
    ✖ "after each" hook for "has an error"
      Chrome 60.0.3112 (Mac OS X 10.11.6)
    Error: Error: Call to console.error from "has an error": brents
        at Context.<anonymous> (/Users/brent/git/cdo/apps/test/unit-tests.js:8536:16)

(2) It prints a stack trace from the error location:

START:
ERROR: '', 'brents'
LOG: 'Error
    at logStack (http://localhost:9876/base/test/unit-tests.js?c55b7fc58799c2620410407ab8a7ff3482416185:8494:12)
    at console.<anonymous> (http://localhost:9876/base/test/unit-tests.js?c55b7fc58799c2620410407ab8a7ff3482416185:8521:10)
    at Object.invoke (http://localhost:9876/base/test/unit-tests.js?c55b7fc58799c2620410407ab8a7ff3482416185:26675:33)
    at console.functionStub (http://localhost:9876/base/test/unit-tests.js?c55b7fc58799c2620410407ab8a7ff3482416185:26459:54)
    at Function.invoke (http://localhost:9876/base/test/unit-tests.js?c55b7fc58799c2620410407ab8a7ff3482416185:24463:52)
    at console.proxy [as error] (http://localhost:9876/base/test/unit-tests.js?c55b7fc58799c2620410407ab8a7ff3482416185:24370:23)
    at Context.<anonymous> (http://localhost:9876/base/test/unit-tests.js?c55b7fc58799c2620410407ab8a7ff3482416185:645185:14)
    at callFn (http://localhost:9876/base/node_modules/mocha/mocha.js?bc2b9e2e7b386b405368c9247d419c9a1d2718c8:4445:21)
    at Test.Runnable.run (http://localhost:9876/base/node_modules/mocha/mocha.js?bc2b9e2e7b386b405368c9247d419c9a1d2718c8:4437:7)
    at Runner.runTest (http://localhost:9876/base/node_modules/mocha/mocha.js?bc2b9e2e7b386b405368c9247d419c9a1d2718c8:4934:10)'
  unit tests
    progressReduxTest
      ✔ has an error
    ✖ "after each" hook for "has an error"

This won't fix the intermittent errors we've been seeing, but will hopefully make tracking them down easier.

[Bjvanminnen]

This passed on my first test run (I was kind of hoping it would fail to validate that the logging is useful). I think there may be value in merging this though, so that we have more logging for the next time someone hits this.

In the meantime, I'm going to rerun and see if I can get a failure.

[islemaster]

Awesome! I'm having a very hard time tracking down some errors in the React upgrade right now (I think they're from dependencies) and this will be super helpful.

[islemaster]

Is there a reason we're printing the stack right away, instead of storing the it and printing it with the stored error after the test? In fact, why not attach the stack to our firstError object?

Just suggestions, this is clearly an improvement without it.

[Bjvanminnen]

No, probably not any good reason. I'll try moving it.

[Bjvanminnen]

i should get rid of this