Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grade band pages #16923

Merged
merged 4 commits into from Aug 8, 2017
Merged

Grade band pages #16923

merged 4 commits into from Aug 8, 2017

Conversation

tanyaparker
Copy link
Contributor

I've set up the student facing pages to allow new variations of the beyond tutorials. I am still updating the gsheet to reflect the new tutorials and ordering. For example, nothing shows up on the Grades K-5 page yet because they will be new carousels with new tags.

BEFORE: express-course page
image

AFTER: express-course page
image

BEFORE: (teacher facing) elementary school page
image

AFTER: (teacher facing) elementary school page
image

Student facing Grades K-5
image

Student facing Grades 6-12
image

Student facing University
image

@breville
Copy link
Member

breville commented Aug 8, 2017

Just aesthetically..

  • New "express-course page" page could have more margin above and below course block.
  • Purple heading & white-on-purple heading seem to compete and I can't tell which is the more dominant.
  • I think we can use vertical spacing more effectively than the horizontal line to separate areas.

position: absolute;
bottom: 0;
margin-bottom: 5%;
}

.educate-button:hover {
background-color: white;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: double indent?


%h2 Looking for courses in other languages?

We are working on translating Courses A-F and the Express Course to languages beyond English. In the meantime, we recommend using
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: very long line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's our line length limit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

---

%link{type: "text/css", href: "/css/learn-carousel.css", rel: "stylesheet"}
%script{type: "text/javascript", src: "/js/bootstrap.min.js"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using bootstrap.js?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, copied from /learn/legacy but I think it was only used for the top Code Studio carousel. I'll remove.

- beyond_categories << {tag:"Web", name: I18n.t(:carousel_heading_webpages)}
- beyond_categories << {tag:"Robot", name: I18n.t(:carousel_heading_robots)}
- beyond_categories << {tag:"IDE", name: I18n.t(:carousel_heading_ide)}
- all_categories = {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be more readable with a single :ruby block instead of - for every line. (Of course, even better is extacting to a separate .rb file.

@breville
Copy link
Member

breville commented Aug 8, 2017

Is there a plan to use real course blocks at some point? Using images feels very hacky :)

@breville breville closed this Aug 8, 2017
@breville breville reopened this Aug 8, 2017
@tanyaparker
Copy link
Contributor Author

We'll be adding the hero banner to these pages to improve the hierarchy of the page and so that the purple H1 headers won't be competing.

@tanyaparker
Copy link
Contributor Author

Oh yeah, pictures is my hack. Erin will be putting in real tiles next. :D


%div{style: "clear:both"}

-tutorials = Tutorials.new(variation=='learn' ? :tutorials : :beyond_tutorials)
- tutorials = Tutorials.new(variation=='learn' ? :tutorials : :beyond_tutorials)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could just get moved up into the :ruby block above. Also the line of ruby below.

@tanyaparker tanyaparker merged commit 21de133 into staging Aug 8, 2017
@tanyaparker tanyaparker deleted the grade-band-pages branch August 8, 2017 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants