New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grade band pages #16923
Grade band pages #16923
Conversation
…ed a layout shift due to change in tile direction
…her copy/style updates
Just aesthetically..
|
position: absolute; | ||
bottom: 0; | ||
margin-bottom: 5%; | ||
} | ||
|
||
.educate-button:hover { | ||
background-color: white; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: double indent?
|
||
%h2 Looking for courses in other languages? | ||
|
||
We are working on translating Courses A-F and the Express Course to languages beyond English. In the meantime, we recommend using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: very long line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's our line length limit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- | ||
|
||
%link{type: "text/css", href: "/css/learn-carousel.css", rel: "stylesheet"} | ||
%script{type: "text/javascript", src: "/js/bootstrap.min.js"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we using bootstrap.js?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, copied from /learn/legacy but I think it was only used for the top Code Studio carousel. I'll remove.
- beyond_categories << {tag:"Web", name: I18n.t(:carousel_heading_webpages)} | ||
- beyond_categories << {tag:"Robot", name: I18n.t(:carousel_heading_robots)} | ||
- beyond_categories << {tag:"IDE", name: I18n.t(:carousel_heading_ide)} | ||
- all_categories = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be more readable with a single :ruby
block instead of -
for every line. (Of course, even better is extacting to a separate .rb
file.
Is there a plan to use real course blocks at some point? Using images feels very hacky :) |
We'll be adding the hero banner to these pages to improve the hierarchy of the page and so that the purple H1 headers won't be competing. |
Oh yeah, pictures is my hack. Erin will be putting in real tiles next. :D |
|
||
%div{style: "clear:both"} | ||
|
||
-tutorials = Tutorials.new(variation=='learn' ? :tutorials : :beyond_tutorials) | ||
- tutorials = Tutorials.new(variation=='learn' ? :tutorials : :beyond_tutorials) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could just get moved up into the :ruby
block above. Also the line of ruby below.
I've set up the student facing pages to allow new variations of the beyond tutorials. I am still updating the gsheet to reflect the new tutorials and ordering. For example, nothing shows up on the Grades K-5 page yet because they will be new carousels with new tags.
BEFORE: express-course page
AFTER: express-course page
BEFORE: (teacher facing) elementary school page
AFTER: (teacher facing) elementary school page
Student facing Grades K-5
Student facing Grades 6-12
Student facing University