Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header: The Pegasus header's user menu & hamburger no longer wrap #16984

Merged
merged 3 commits into from Aug 14, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
37 changes: 25 additions & 12 deletions dashboard/app/assets/stylesheets/application.scss
Expand Up @@ -403,6 +403,8 @@ img.video_thumbnail {

.user_menu {
margin-top: 6px;
height: 38px;
user-select: none;

.user_name {
max-width: 120px;
Expand All @@ -413,10 +415,28 @@ img.video_thumbnail {
white-space: nowrap;
}

.user_menu_glyph {
display: inline-block;
float: left;
padding-left: 5px;
.user_menu_arrow_down,
.user_menu_arrow_up {
font-size: 30px;
}

.user_options {
position: absolute;
top: 55px;
right: 55px;
}

.user_menu_arrow_down,
.user_menu_arrow_up {
font-size: 25px;
}

.user_menu_arrow_up {
margin-top: -3px;
}

.user_menu_arrow_down {
margin-top: -2px;
}
}

Expand All @@ -433,12 +453,6 @@ img.video_thumbnail {
padding-left: 20px;
}

.user_menu {
.user_options {
top: 37px;
}
}

#signin_button .header_button {
margin-top: 6px;
}
Expand Down Expand Up @@ -982,8 +996,7 @@ $default-modal-width: 640px;

.header_right {
position: absolute;
float: left;
right: 25px;
right: 16px;
}

.freeplay_links {
Expand Down
50 changes: 26 additions & 24 deletions dashboard/app/views/shared/_user_header.html.haml
Expand Up @@ -5,28 +5,28 @@
%span= t('nav.user.label', username: t('nav.user.team'))
- else
%span.user_name= t('nav.user.label', username: h(current_user.short_name))
%span.user_menu_glyph
▼
%div{style: 'position: relative; top: 3px;'}
.user_options{style: 'display: none;'}
- if current_user.can_pair?
- if session[:pairings].present?
= link_to '#', {id: 'pairing_link', style: 'display: none'} do
%i.fa.fa-user-plus
= t('nav.user.pair_programming')
.pairing_summary
#{t('nav.user.driver')}:
= h(current_user.short_name)
- session[:pairings].map do |id|
%br
#{t('nav.user.navigator')}:
= h(User.find(id).short_name)
- else
= link_to '#', {id: 'pairing_link', style: 'display: none'} do
%i.fa.fa-user-plus
= t('nav.user.pair_programming')
= link_to t('nav.user.settings'), edit_user_registration_url
= link_to t('nav.user.logout'), destroy_user_session_url
 
%i.user_menu_arrow_down{class: "fa fa-caret-down"}
%i.user_menu_arrow_up{class: "fa fa-caret-up", style: "display: none"}
.user_options{style: 'display: none'}
- if current_user.can_pair?
- if session[:pairings].present?
= link_to '#', {id: 'pairing_link', style: 'display: none'} do
%i.fa.fa-user-plus
= t('nav.user.pair_programming')
.pairing_summary
#{t('nav.user.driver')}:
= h(current_user.short_name)
- session[:pairings].map do |id|
%br
#{t('nav.user.navigator')}:
= h(User.find(id).short_name)
- else
= link_to '#', {id: 'pairing_link', style: 'display: none'} do
%i.fa.fa-user-plus
= t('nav.user.pair_programming')
= link_to t('nav.user.settings'), edit_user_registration_url
= link_to t('nav.user.logout'), destroy_user_session_url
- else
= link_to new_user_session_url, class: 'button-signin', id: 'signin_button' do
.header_button.header_user
Expand All @@ -35,14 +35,16 @@
:javascript
function hideUserOptions() {
$('.user_options').slideUp();
$('.user_menu_glyph').html('▼');
$('.user_menu_arrow_down').show();
$('.user_menu_arrow_up').hide();
$(document).off('click', hideUserOptions);
}
$('.user_menu').click(function (e) {
if ($('.user_options').is(':hidden')) {
e.stopPropagation();
$('.user_options').slideDown();
$('.user_menu_glyph').html('▲');
$('.user_menu_arrow_down').hide();
$('.user_menu_arrow_up').show();
$(document).on('click', hideUserOptions);

$("#hamburger-icon").removeClass('active');
Expand Down
27 changes: 19 additions & 8 deletions shared/css/header2.scss
Expand Up @@ -54,8 +54,8 @@
}

#right {
float: right;
padding-right: 15px;
right: 16px;
position: absolute;
}

#headerlinks {
Expand Down Expand Up @@ -112,6 +112,8 @@
background-color: transparent;
border: 2px solid $white;
margin-top: -4px;
height: 38px;
user-select: none;

.user_name {
font-family: 'Gotham 4r', sans-serif;
Expand All @@ -123,14 +125,23 @@
float: left;
}

.user_menu_glyph {
display: inline-block;
float: left;
padding-left: 5px;
.user_options {
position: absolute;
top: 55px;
right: 55px;
}

.user_options {
top: 37px;
.user_menu_arrow_down,
.user_menu_arrow_up {
font-size: 25px;
}

.user_menu_arrow_up {
margin-top: -3px;
}

.user_menu_arrow_down {
margin-top: -2px;
}
}

Expand Down