Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scrolling to teacher dashboard test #17000

Merged
merged 1 commit into from Aug 10, 2017
Merged

Conversation

epeach
Copy link

@epeach epeach commented Aug 10, 2017

Added scrolling fixes browser size specific error where save button was off screen and couldn't be engaged.

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, @epeach ! It sounds like you've verified this fix locally, which seems good enough. In the future if you want to test in Firefox and other browsers on CircleCI, you can do so by including "[test all]" in your commit message.

@islemaster
Copy link
Contributor

@davidsbailey that's not correct. [test all] will cause all unit tests to run, regardless of which files changed (where normally we try to only run suites that might have been affected).

You can enable UI tests for specific browsers with [test firefox], [test ie], [test safari], etc.

See what tags are available and what they do in circle.rake.

@davidsbailey
Copy link
Member

Ah, good to know! Thanks @islemaster

@epeach epeach merged commit 9302213 into staging Aug 10, 2017
@epeach epeach deleted the section-flow-homepage-error branch August 16, 2017 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants