Improve AdminSearchController#find_students. #17018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashercodeorg
force-pushed
the
fixFindStudents
branch
from
aae3e78
to
6c24609
Compare
|
FYI @Hamms. |
ashercodeorg
commented
Aug 11, 2017
| get :find_students, params: {teacherNameFilter: 'multiple'} | ||
|
|
||
| assert_response :success | ||
| assert_select '.container .alert-danger', 'Multiple teachers matched the name and email search criteria.' |
There was a problem hiding this comment.
Note that I don't understand why the assert_equal message, flash[:alert] syntax fails.
There was a problem hiding this comment.
Intersting also that it's (presumably) working for the undelete_section tests but not for the lookup_section test
There was a problem hiding this comment.
Yeah, I noticed. Honestly, I didn't spend almost any time trying to understand, it didn't seem worth it.
|
@Hamms: This LG? |
Hamms
approved these changes
Aug 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes several improvements and fixes:
In doing so, resolves this HB error (namely
NoMethodError: undefined method 'students' for nil:NilClass) happening when the searched section does not exist.EXAMPLE WARNING (section not found):