Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show the "Leave section" button to students in OAuth sections #17047

Merged
merged 1 commit into from Aug 14, 2017

Conversation

joshlory
Copy link
Contributor

@joshlory
Copy link
Contributor Author

This component still shows the G- section code. My understanding was that this component will be merged with the proper SectionTable component? Cleaner to implement this via providerManaged if these components are not going to be merged in the future.

@Bjvanminnen
Copy link
Contributor

My understanding (which may be imperfect) is that SectionsTable will go away after the section-flow-2017 experiment becomes enabled. Presumably that implies we'll want to make this same sort of change there?

onClick={this.onLeave.bind(this, section.code, section.name)}
color={Button.ButtonColor.gray}
/>
{!/^(C|G)-/.test(section.code) &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might make a helper method called something like isOauthSection(section) that can include a comment about what this regex is doing/why we can only leave oauth sections.

@Bjvanminnen
Copy link
Contributor

Apparently SectionsTable will not go away completely, as it will still be used by the StudentSections component.

@joshlory
Copy link
Contributor Author

@poorvasingal does this mean we need to hide the G- and C- codes for the SectionsTable component? I was asked not to do that work because it was going to be duplicating logic in the SectionTable component, which was to replace this component on the Studio home page.

@joshlory joshlory merged commit e1c72d7 into staging Aug 14, 2017
@joshlory joshlory deleted the oauth-section-no-leave-button branch August 14, 2017 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants