Run deploy_to_levelbuilder on weekday afternoons. #17173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashercodeorg
force-pushed
the
cronLevelbuilder
branch
from
4a26f2b
to
7c8e43c
Compare
Erin007
reviewed
Aug 23, 2017
| # Double-escape the command string, once for each remote shell we're passing through. | ||
| system "ssh -t gateway.code.org ssh -t #{server} #{command.inspect.inspect}" | ||
| end | ||
|
|
||
| # Creates a new branch with the given name from the given commit on the test server | ||
| # (without checking it out) and pushes it to GitHub. | ||
| # @param [String] branch_name The name of the branch to create. | ||
| # @param [String] commit The sha of the commit to base the branch at. | ||
| # TODO(asher): Move this to a location for better reuse, deduplicating existing copies of it. |
There was a problem hiding this comment.
Is this something that can be done along with these changes? Or is the TODO comment no longer applicable?
There was a problem hiding this comment.
Good Q. Definitely still relevant, though a slightly moving target as the deploy_to_test, deploy_to_levelbuilder, and scoop_content (soon to be commit_content) scripts change. Ideally (IMO), I'll resolve the TODO after the scripts settle, that way I know the best API to offer.
For example, I would have done things "wrong" originally, based on wjordan's (good) suggestion that the only cross environment interaction should be through PR merges.
Erin007
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per feedback from @wjordan, this is being made to run on the
testmachine as it executes commands on that machine (namely, creating and pushing a new branch).As such, this PR includes some code changes to reflect this. This PR also deletes the branch after merge, something missed in #17163.