Take your account with you UI changes #17221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@poorvasingal please take a look at the images, see if these are what you had in mind. I reordered some elements the way the doc seemed to suggest. |
breville
approved these changes
Aug 23, 2017
|
Oh, is there any testing of this UI? Seems like it would be great to have some. |
|
Cool, looks good. Just a couple of comments:
|
|
Suggestion: "Enter your parent or..." rather than "Enter in your parent or..." |
|
@poorvasingal, the deleting accounts text is that way right now in production, that's not part of this changeset (this change just makes the header teal). Would you like me to change that to something else? |
|
(Spoke with Poorva, we'll leave the delete text alone for now) |
ewjordan
commented
Aug 23, 2017
| .field | ||
| = form.label :password, maxlength: 255 | ||
| = form.password_field :password, autocomplete: 'off', maxlength: 255 | ||
| .field | ||
| = form.label :password_confirmation | ||
| = form.password_field :password_confirmation, autocomplete: 'off', maxlength: 255 | ||
| - if current_user.secret_word_account? | ||
| %h3= t('user.confirm_secred_words') |
There was a problem hiding this comment.
Grr, I typoed this by accident, I don't know how I didn't catch that. Fixing in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Item 1 in https://docs.google.com/document/d/1R8oBFcixpN1X_FQJq9G5-l3AbaqjGSqvD9oDwL00Wns/edit#heading=h.ezfouxcqg3na
(Update) New text for enter_parent_email: "Enter your parent or guardian's email address (for password recovery)"
Personal word login (with email):
Personal word login (no email - note, parenthetical "to recover password" is now removed, though it was not when I took this screenshot):
Personal picture login:
Delete account button:
