Followup to Bugfix: PropType error in AddSectionDialog #17224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewjordan
approved these changes
Aug 23, 2017
|
Update: The regression in this PR is worse than I thought (it's impossible to create a new section with this button) so we're prepping a hotfix with just the first commit from this PR (#17233) and this will end up being just the cleanup in the remaining two commits. |
|
LGTM. I've hit this sort of issue before too :( |
islemaster
force-pushed
the
fix-proptype-error
branch
from
20f8a76
to
9687c58
Compare
islemaster
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ewjordan reported a PropType error when adding a new section from the teacher homepage:
I introduced this regression while doing cleanup after we enabled the
section-flow-2017experiment. Click event arguments were accidentally being passed through to thebeginEditingNewSectionfunction, which has optional arguments but in this case should have been called with none.I've fixed the problem in
OwnedSections, updated a workaround for the same issue inSetUpSectionsto follow the same pattern, and written unit tests in both places to prevent this from regressing in the future.