Add dynamic options to pd_form #17226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoby
force-pushed
the
pd-form-dynamic-options
branch
from
3fb2541
to
1136d97
Compare
Hamms
approved these changes
Aug 23, 2017
| @@ -39,7 +44,7 @@ def validate_required_fields | |||
| # empty fields may come about when the user selects then unselects an | |||
| # option. They should be treated as if they do not exist | |||
| hash.delete_if do |_, value| | |||
| value.empty? | |||
| value.blank? | |||
There was a problem hiding this comment.
I encountered an error at some point during development because I had a nil (rather than empty) value. I don't remember how I got there, but blank? covers nil and empty?.
Is there a reason we'd want to preserve nil values?
|
Good suggestion. I'll add a comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.