enable applab embed ui tests on safari and firefox #17298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
force-pushed
the
fix-applab-embed
branch
2 times, most recently
from
2f52508
to
d3b9e95
Compare
davidsbailey
changed the title
davidsbailey
force-pushed
the
fix-applab-embed
branch
from
d3b9e95
to
fc1ffc4
Compare
davidsbailey
force-pushed
the
fix-applab-embed
branch
from
e3496d3
to
fc1ffc4
Compare
|
Merging with a green-enough circle run https://circleci.com/gh/code-dot-org/code-dot-org/47251 . Only the applab_embed and teacher-dashboard UI tests should be affected by these changes, and those are passing in all 3 browsers which ran. |
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
applab embed ui tests have been disabled on firefox for some time now, and were recently disabled on Safari in #17297 after they were broken on Safari by #17133 . The previous implementation of this test (before PR 17133) no longer works because using jquery to inspect the iframe contents gives a same origin policy violation, now that applab (which is loaded within the iframe) uses firebase.
Description
This PR fixes the applab embed ui test on Safari by waiting for the iframe to load before telling selenium to switch to it, which avoids a timeout during the
switch_to.frameoperation in Safari. I also verified that the test is passing in Firefox after this change, although I did not explore why it was disabled in the first place.