fix user_menu display on old pages #17332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested manually on an adhoc instance, no guarantees it will pass all tests/lints until CI runs through it however. |
balderdash
approved these changes
Aug 25, 2017
|
Circle failure is unrelated, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix/followup to #17044 / #16614, this should make the sign-in button render via ajax correctly on old pages again.
The
user_menuaction requires the default Rails layout to render correctly. In order to apply this withrender file, we need to put the call torender filein its own haml (in the default/conventional file location) so it will be rendered with the layout around it.