Show breakpoints, warnings and errors in App Lab again #17382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjvanminnen
reviewed
Aug 29, 2017
| var gutterLine = $(".droplet-gutter-line").filter(function (index) { return $(this).text() === "#{line}"; }); | ||
| var x = gutterLine.offset().left + 5; | ||
| var y = gutterLine.offset().top + 5; | ||
| gutterLine.simulate( 'mousedown', { |
There was a problem hiding this comment.
super nit that i dont really care about: space before 'mousedown'
Bjvanminnen
approved these changes
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When droplet moved to SVG in #16917 , it inadvertently lost the ability to show breakpoints, warnings and errors in the gutter next to the line number. Pull in a fix for this from droplet-editor/droplet#205, and add a simple eyes test.
Fixes axosoft item https://codeorg.axosoft.com/viewitem?id=1053&type=features&force_use_number=true