Add a Finish button to Collector #17428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
force-pushed
the
collector-finish-button
branch
from
82d9921
to
fb8f82a
Compare
joshlory
approved these changes
Sep 1, 2017
…type used for feedback display logic
…ption Rather than hacking in the functionality by mutating the test result into something it shouldn't be
Hamms
force-pushed
the
collector-finish-button
branch
from
fb8f82a
to
108b4b0
Compare
Hamms
added a commit
that referenced
this pull request
Sep 14, 2017
Previously, Maze levels were assuming that any kind of non-optimal result implied a non-passing result; this is because we were formerly not using the `APP_SPECIFIC_ACCEPTABLE_FAIL` result for any Maze levels. I thought I had caught all the places where Maze was making this assumption in #17428, but it turns out I was missing one in the milestone report, the results of which are used by the "continue" button in the success dialog to determine whether or not clicking it will advance us on to the next level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also slightly tweak the Collector successs workflow. We now want to no longer automatically send you on to the next level with a congrats dialog when you pass the level with fewer than all of the gems; we now only do that if you collect all gems on the level.
If you collect enough gems to pass the level but not all of them, we give you the congrats message in the top instructions and enable the "finish" button:
You can then move on either by continuing to iterate and eventually perfecting the level, or simply by hitting the "finish" button at any time: