Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the old, linear-style DOTD script. #17473

Merged
merged 1 commit into from Sep 1, 2017
Merged

Delete the old, linear-style DOTD script. #17473

merged 1 commit into from Sep 1, 2017

Conversation

ashercodeorg
Copy link
Contributor

@ashercodeorg ashercodeorg commented Sep 1, 2017 •
edited

The new DOTD script is menu-drive and lives at bin/dotd.

@ashercodeorg
Copy link
Contributor Author

@Bjvanminnen: Assigning to you, as upcoming DOTD. It isn't clear to me whether we are ready to delete this from our repository or if it should stick around a bit longer. Please exercise your judgement when this should be merged (possibly after my departure), merging it yourself when appropriate.

Bjvanminnen
Bjvanminnen approved these changes Sep 1, 2017
View reviewed changes
Copy link
Contributor

@Bjvanminnen Bjvanminnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see much value in keeping it - especially considering it will still exist in repo history.

@ashercodeorg ashercodeorg merged commit a4ca77b into staging Sep 1, 2017
@ashercodeorg ashercodeorg deleted the killDotdOld branch September 1, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bjvanminnen Bjvanminnen Bjvanminnen approved these changes

Assignees
No one assigned
Labels
code-hygiene
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashercodeorg @Bjvanminnen