Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint the Gemfile when linting ruby in commit hooks #17534

Merged
merged 1 commit into from
Sep 5, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/hooks/lint.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def filter_eslint_shared(modified_files)
end
end

RUBY_EXTENSIONS = ['.rake', '.rb', 'Rakefile'].freeze
RUBY_EXTENSIONS = ['.rake', '.rb', 'Rakefile', 'Gemfile'].freeze
def filter_rubocop(modified_files)
modified_rb_rake_files = modified_files.select do |f|
RUBY_EXTENSIONS.any? {|ext| f.end_with? ext}
Expand Down