Fix 500 error in /yourschool page #17547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /yourschool page after my recent change to include the school control works locally but fails on staging/test or if you don't run dashboard and pegasus in the same process locally. It turns out some HAML that was copied from dashboard to pegasus was relying on the
SchoolInfoconstants which are defined elsewhere in dashboard. This lucked out and worked locally where dashboard and pegasus run in the same process, but fails in the real world where dashboard and process are separate. The fix is to replace the constants with the literal values on the pegasus side. We are planning to remove this control and replace it with a new autocomplete control, otherwise I would look at moving the constants into some shared place.