React: Remove uses of React.createClass in applab/* #17570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
force-pushed
the
react-no-createclass
branch
from
db29926
to
c6c589b
Compare
islemaster
changed the title
davidsbailey
reviewed
Sep 7, 2017
| this.makeDraggable(); | ||
| }, | ||
| } |
There was a problem hiding this comment.
seems like these need to be bound since they access this, is that correct?
There was a problem hiding this comment.
Lifecycle methods don't need to be bound - React calls them in the component's context already.
davidsbailey
reviewed
Sep 7, 2017
| return this.props.isShareView || !this.props.hasDesignMode; | ||
| }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
As far as I could tell, this helper is always invoked directly from this (i.e. this.shouldHideToggle()) and never passed around as a callback (e.g. onClick={this.shouldHideToggle}) so there isn't a need to bind it.
davidsbailey
approved these changes
Sep 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work extracted from #16861 getting us ready to update to React 15.6+.
I'm breaking the ES6-ification of our React components up into several PRs because they're fairly significant changes and it'll be easier to introduce regressions, so I'd like them to be reviewed more carefully. This first batch is components within src/applab.