Fix bug where enrollments with attendance could be canceled and break… #17597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehalshah
approved these changes
Sep 7, 2017
| @@ -89,6 +89,8 @@ def cancel | |||
| @enrollment = Pd::Enrollment.find_by_code params[:code] | |||
| if @enrollment.nil? | |||
| render_404 | |||
| elsif !@enrollment.attendances.empty? | |||
There was a problem hiding this comment.
Prefer any? instead of negating empty
| @@ -0,0 +1,5 @@ | |||
| %p | |||
| You have already attended this workshop. | |||
| %p | |||
There was a problem hiding this comment.
Nested <p> tags intentional?
There was a problem hiding this comment.
Copied from here. I'll fix that one too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… payment reports
Error in the wild
Task
This fix is in 2 parts:
Include deleted enrollments in the payment calculator (+ unit test). This will fix the issue where it breaks payment reports. Note: without the new
with_deletedaddition, the new test case fails in the same was as the above error.Block canceling enrollments that have attendance in the first place.