Fix flaky section signin test #17609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balderdash
approved these changes
Sep 8, 2017
islemaster
approved these changes
Sep 8, 2017
| @@ -56,12 +56,15 @@ Scenario: Join non-existent section from sign in page shows error | |||
| And I type "9999999999" into "#section_code" | |||
| And I click selector "#section_form .btn-primary" | |||
| Then I wait until I am on "http://studio.code.org/courses" | |||
| Then I wait to see ".alert-danger" | |||
| And element ".alert-danger" contains text "Could not find a section with code" | |||
There was a problem hiding this comment.
This is great. Possible alternative:
And element ".alert-danger" eventually contains text "Could not find a section with code"| Scenario: Join existing section from sign in page goes to section join page | ||
| Given I sign out | ||
| Given I am on "http://studio.code.org/users/sign_in/" | ||
| And I type the section code into "#section_code" | ||
| And I click selector "#section_form .btn-primary" | ||
| Then I wait until current URL contains "http://studio.code.org/join" |
There was a problem hiding this comment.
Again, great. I think you could also
And I press the first "#section_form .btn-primary" element to load a new page
And element ".main" eventually contains text "Register to join the class"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some waits into a sign-in test that was not seeing the expected text (though visual inspection tended to show that it was there). Removing the @no_ie and @no_safari tags, under the theory that those are not actually browser-specific failures but were just because of timing-dependence.