React: Remove uses of React.createClass in code-studio/pd/workshop_dashboard #17612
Conversation
islemaster
force-pushed
the
react-no-createclass-worshop_dashboard
branch
from
80e317e
to
c9cc54c
Compare
islemaster
changed the title
There was a problem hiding this comment.
What's the general urgency on this change? I ask because our testing in this area still has a ways to go - and if something is broken it's going to hard to find.
Have you been able to bring up the workshop dashboard and view workshops in various states? If not, I can show you how
|
Non-urgent, just doing some code cleanup to get us ready for a React upgrade. I'd appreciate a walkthrough sometime this week on how to manually test workshop dashboard, and I'm also more than happy to break this up into smaller PRs. |
|
No need to break up into smaller PRs. I would like to walk through some scenarios and make sure we didn't break anything before merging though. |
|
We've got some merge conflicts and some of my PRs from before my vacation caused some regressions too, so I am actually going to break this up into smaller PRs. I'll open the first momentarily. |
More work extracted from #16861 getting us ready to update to React 15.6+.
React.createClassis deprecated, and I'm slowly upgrading our components to ES6 classes.This second batch is components within src/code-studio/pd/workshop_dashboard. I've never made changes in this area, and could especially use help verifying the changes to
contextTypesdon't mess with any of the react-router behaviors.