Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable animation for snowflake block tests #17724

Merged
merged 1 commit into from
Sep 21, 2017
Merged

Disable animation for snowflake block tests #17724

merged 1 commit into from
Sep 21, 2017

Conversation

balderdash
Copy link
Contributor

This speeds up the snowflake block tests from ~13s to ~8s on my machine, hopefully that's enough of a speedup to keep them under the 20s timeout on circle.

@balderdash balderdash force-pushed the disable-animation branch 2 times, most recently from a1c39ed to 454b165 Compare September 14, 2017 04:51
Hamms
Hamms approved these changes Sep 21, 2017
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love that both execute and animate have to have some understanding of how the setting works, but I definitely love the idea of the setting.

LGTM all things considered

@balderdash balderdash merged commit 3a735fa into staging Sep 21, 2017
@balderdash balderdash deleted the disable-animation branch September 21, 2017 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

Assignees

@Hamms Hamms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@balderdash @Hamms