Use name instead of course_name for Clever section import #18094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
approved these changes
Oct 3, 2017
|
I manually logged in as a user having issues, and watching the network traffic noticed that the course name was null. Ended up finding https://dev.clever.com/reference#getsection which showed that it's an optional field. We might have issues with course_number as well, but we'll deal with that if it comes up, that one is trickier to fix because there's no obvious replacement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that course_name is an optional field in Clever, whereas name will always be present. We've had a few Zendesk tickets where teachers were unable to import because they were having errors, this will hopefully resolve those problems.