Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "enable cloning of DSL-defined levels"" #18126

Merged
merged 2 commits into from Oct 5, 2017

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Oct 4, 2017

Reverts #18115

The original PR failed on test:

  test_should_clone                                              ERROR (0.13s)
NoMethodError:         NoMethodError: undefined method `dsl_text' for #<Blockly:0x0000002e781cb0>
            app/controllers/levels_controller.rb:215:in `clone'
            app/controllers/application_controller.rb:145:in `block in with_locale'
            app/controllers/application_controller.rb:144:in `with_locale'
            test/controllers/levels_controller_test.rb:636:in `block (2 levels) in <class:LevelsControllerTest>'
            test/test_helper.rb:117:in `block in assert_creates'
            test/test_helper.rb:116:in `assert_creates'
            test/controllers/levels_controller_test.rb:635:in `block in <class:LevelsControllerTest>'
            test/testing/setup_all_and_teardown_all.rb:22:in `run'

@Hamms Hamms requested review from wjordan and joshlory October 4, 2017 18:24
@Hamms Hamms merged commit c4054c5 into staging Oct 5, 2017
@Hamms Hamms deleted the revert-18115-revert-17611-clone-dsl-defined branch October 5, 2017 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants