Project gallery -> Projects #18135
Project gallery -> Projects #18135
Conversation
|
cc: @tanyaparker |
|
I also changed the string in the i18n gsheet for pegasus from "Project Gallery" to "Projects". |
apps/i18n/common/en_us.json
Outdated
| "projectsViewOldGallery": "View old gallery with other project types", | ||
| "projects": "Projects", | ||
| "projectsSubHeading": "Students have created over 20 million projects", |
There was a problem hiding this comment.
Sorry, didn't update TODO list with the copy. The string should be "Over 20 million projects created"
Is it possible to do formatting and somehow make the 20 million more bold and more big?
There was a problem hiding this comment.
We can either have a localized string OR we can style the 20 million differently than the rest of the string. My understanding is that for translations to be successful we can't translate substrings and then put them back together because maybe the ordering matters in different languages, etc. What's your preference?
There was a problem hiding this comment.
Merp. Ok, let's go with localized > formatting.
There was a problem hiding this comment.
I don't see header_project_gallery (the name of the key for the string "Project Gallery" in the pegasus gsheet) used anywhere in the codebase. Perhaps worth simply removing from the gsheet? OTOH I can't find many of the strings from that gsheet in the codebase, so it's possible I'm missing something.
Erin007
force-pushed
the
project-gallery-link-updates
branch
from
7e64ebe
to
50b9868
Compare
This PR changes "Project Gallery" to "Projects" in the navbar, hamburger, projects page title and link to the projects page from /home. It also moves "Projects" in the navbar list and adds a subheading to the
ProjectHeader.Signed out projects before:
Signed out projects after:
Signed in projects before:
Signed in projects after:
hamburger dropdown before:
hamburger dropdown after:
/home link before:
/home link after:
