expose pairing_channel_id, use with getPathName() for pairing URL #18141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjvanminnen
reviewed
Oct 4, 2017
apps/src/StudioApp.js
Outdated
| @@ -509,6 +509,11 @@ StudioApp.prototype.alertIfCompletedWhilePairing = function (config) { | |||
| {msg.pairingNavigatorLink()} | |||
| </a> | |||
| } | |||
| {config.level.pairingChannelId && | |||
| <a href={window.dashboard.project.getPathName('view', config.level.pairingChannelId)}> | |||
There was a problem hiding this comment.
We now import project (rather than relying on window.dashboard), so I think you can just do project.getPathName
Bjvanminnen
reviewed
Oct 4, 2017
| * @returns {string} Url to the specified action. | ||
| * @throws {Error} If this type of project does not have a standalone app. | ||
| */ | ||
| getPathName(action) { | ||
| var pathName = this.appToProjectUrl() + '/' + this.getCurrentId(); | ||
| getPathName(action, projectId) { |
There was a problem hiding this comment.
with ES6 we can express this as getPathName(action, projectId = this.getCurrentId)
Bjvanminnen
reviewed
Oct 4, 2017
| var pathName = this.appToProjectUrl() + '/' + this.getCurrentId(); | ||
| getPathName(action, projectId) { | ||
| projectId = projectId || this.getCurrentId(); | ||
| var pathName = this.appToProjectUrl() + '/' + projectId; |
There was a problem hiding this comment.
nit: let instead of var
Bjvanminnen
reviewed
Oct 4, 2017
| @@ -307,7 +307,7 @@ def user_progress_for_stage | |||
| elsif level.channel_backed? | |||
| @level = level | |||
| recent_channel = safe_get_channel_for(level, recent_user) if recent_user | |||
| response[:pairingAttempt] = send("#{level.game.app}_project_view_projects_url".to_sym, channel_id: recent_channel) rescue nil if recent_channel | |||
| response[:pairingChannelId] = recent_channel if recent_channel | |||
There was a problem hiding this comment.
I like this approach of sending a channel Id instead 👍
Bjvanminnen
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getStandaloneApp()- seecode-dot-org/apps/src/code-studio/initApp/project.js
Line 528 in 23a245f
pairing_attemptURL for channel-backed levels, we instead generate apairing_channel_idand move the URL generation to the client-side where we already have access to the special client-side code