still Project Gallery on dashboard #18187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't been following along with all the issues today. As long as we don't ship with an inbetween state where pegasus and dashboard have different strings, then I'm ok with whatever you need to do to get staging open. Assuming since DTP is at risk today we won't ship with that inbetween state? |
|
correct - no intention to DTP with the difference, just clearing the test on staging. |
|
👍 |
|
Oops, out of muscle memory/brain glitch I just deleted your branch. lol Hope you don't mind. If you need it again feel free to restore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the navbar link is "Projects" on pegasus and "Project Gallery" on dashboard (while we're in this weird temporary state). This change makes
header.featurematch the current state in attempt to unblock the pipeline.