New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
temporarily put a notification on the top of certain scripts #18190
Conversation
notice="This course has recently been updated!" | ||
details="See what changed and how it may affect your classroom" | ||
buttonText={i18n.learnMore()} | ||
buttonLink="TODO" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still awaiting this URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Pulled and did manual testing on localhost.
// This notification is a temporary hack we want to stick on a few courses. We | ||
// expect to remove it in the near future, and build a longer term solution | ||
// for adding notifications to specific scripts that is LB based. | ||
const announcementCourses = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Notification | ||
type={NotificationType.information} | ||
notice="This course has recently been updated!" | ||
details="See what changed and how it may affect your classroom" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're cool with not localizing this text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I would put a period at the end of this sentence.
We want to temporarily put this notification on the top of a couple of scripts. This is a short-term pragmatic hack.