New header: with smaller header, reduce gap above level #18293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
requested review from
Hamms,
joshlory,
tanyaparker,
Erin007,
islemaster and
Bjvanminnen
joshlory
approved these changes
Oct 11, 2017
Erin007
approved these changes
Oct 11, 2017
islemaster
approved these changes
Oct 11, 2017
breville
added a commit
that referenced
this pull request
Oct 11, 2017
Followup to #18293. With the gap removed, restore the space to the HeaderBanner used on /home and /courses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Testing
I went through one level from each stage in
/s/allthethingsat desktop size and Minecraft seemed to be the only type with an issue, in particular needing the same treatment independently. (Though it seems it got some extra spacing, maybe to give its own logo some breathing room.)Minecraft before
Minecraft after