Internet Simulator: Reduce request size limit from 5MB to 50KB #18314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last week we implemented some monitoring and a generous 5MB limit on NetSim request sizes. After a few days of monitoring regular traffic on our new dashboard, I think we can state with confidence that the 5MB limit was at least 100 times too large.
The largest message requests we've seen in the last three days come in just under 10KB. They've hit that value a few times, so it's a good guess that this is the largest message size we normally allow through normal client use. Message requests are also our largest request type by far, over the last three days:
I've decided to lower the limit from 5MB to 50KB, which should still be a fairly generous.