Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet Simulator: Reduce request size limit from 5MB to 50KB #18314

Merged
merged 1 commit into from Oct 12, 2017

Conversation

islemaster
Copy link
Contributor

Last week we implemented some monitoring and a generous 5MB limit on NetSim request sizes. After a few days of monitoring regular traffic on our new dashboard, I think we can state with confidence that the 5MB limit was at least 100 times too large.

screenshot from 2017-10-11 14-23-10

The largest message requests we've seen in the last three days come in just under 10KB. They've hit that value a few times, so it's a good guess that this is the largest message size we normally allow through normal client use. Message requests are also our largest request type by far, over the last three days:

Request Average Max
Message ~230B 9.01KB
New node ~75B 169B
Node update ~160B 167B
New wire ~120B 167B
New log ~150B 1.82KB

I've decided to lower the limit from 5MB to 50KB, which should still be a fairly generous.

@islemaster islemaster requested a review from Hamms October 11, 2017 21:46
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, I love data-driven decisions

@islemaster islemaster merged commit ec7164c into staging Oct 12, 2017
@islemaster islemaster deleted the stricter-netsim-limits branch October 12, 2017 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants