Fix adhoc build #18325
Merged
Fix adhoc build #18325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
|
tested fix manually via thanks @davidsbailey for help reporting + investigating this issue. |
|
Awesome @wjordan , thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the adhoc build by tweaking the converge-order of some of the Chef resources updating the instance. Specifically, the
service[dashboard]resource was running after the Git-repo was updated to new code but before theexecute[build-cdo]resource, causing new initializer code depending on recent migrations to fail on startup. This out-of-order converging was also happening when the Rubyapt-package update was causing the dashboard service to reload too early.With these changes, the
build-cdoresource gets run before the dashboard-service reload in both cases, allowing adhoc instances to be created successfully when updating from the base image.