Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Optimizely script on Hoc.com #18341

Merged
merged 2 commits into from Oct 13, 2017
Merged

Update Optimizely script on Hoc.com #18341

merged 2 commits into from Oct 13, 2017

Conversation

tanyaparker
Copy link
Contributor

Remove it from HourofCode.com theme and only include it on each individual page we need it on. To follow the same optimal behavior like how we use Optimizely on Code.org.

@breville
Copy link
Member

Is top of page most efficient? Sometimes it's possible to include at bottom of page but not sure if that'll be the case here...

@tanyaparker
Copy link
Contributor Author

Should I try it on the bottom first?

@breville
Copy link
Member

Hmm, this looks to be a "classic" snippet? In fact, they recommend inside <head>: https://help.optimizely.com/Set_Up_Optimizely/Implement_the_snippet_for_Optimizely_Classic

@tanyaparker
Copy link
Contributor Author

tanyaparker commented Oct 13, 2017

Going to merge for now and see if I can optimize later to load the script in <head>. We need to get the test ready before 10/18 blast.

@tanyaparker tanyaparker merged commit bfb6e56 into staging Oct 13, 2017
@tanyaparker tanyaparker deleted the hoc-optimizely branch October 13, 2017 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants