Add a UI test for level swapping #18362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balderdash
force-pushed
the
level-swap-ui-test
branch
from
036105b
to
c8739dc
Compare
balderdash
force-pushed
the
level-swap-ui-test
branch
from
c8739dc
to
fef81ca
Compare
joshlory
approved these changes
Nov 16, 2017
balderdash
force-pushed
the
level-swap-ui-test
branch
from
5718fc8
to
fef81ca
Compare
balderdash
force-pushed
the
level-swap-ui-test
branch
from
fef81ca
to
cbd8ad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this test as part of the abandoned levelswapping bugfix from a month ago (the bug where swapped levels that change from a video to a puzzle have the wrong bubble icon for people who had progress on the old level).
The code change was a little too big/risky given the impact of that bug, but this test is still useful.