add page listing tools for Workshop Admins #18393
Conversation
|
@tanyaparker Can you create a Trello card for this one? By the way - I implemented the Regional Partner Mappings functionality at the bottom of the Regional Partner "show" view, so there's only one link for all 3 features: edit Regional Partners, assign Program Managers, and add/remove Mappings |
| @@ -0,0 +1,7 @@ | |||
| class Pd::WorkshopAdminsController < ApplicationController | |||
| authorize_resource class: :pd_workshop_user_management | |||
There was a problem hiding this comment.
This isn't really related to a pd_workshop_user_management resource. I don't want to create unnecessary overhead, but I wonder if it might be better to create a "resource" symbol just for this directory, or even just to explicitly check for that permission?
At the very least add a comment stating this resource is a stand in for workshop_admin permissions, and if anything changes wrt that resource ability, we'll need to separate them. We do have unit tests, so I'm not very concerned about it sneaking up on us, and it's unlikely to change.
There was a problem hiding this comment.
I created a dedicated resource symbol (pd_workshop_admins) for this page
# Conflicts: # dashboard/config/routes.rb
Spec: https://docs.google.com/document/d/1iaMcfalaH01Mw45Aze4iFqXh7ujXgBwhb0ybLrIunlg/edit