React: Convert storybook-specific components to ES6 #18417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balderdash
approved these changes
Oct 17, 2017
| }; | ||
| }, | ||
| class StorybookHarness extends React.Component { | ||
| state ={value: 0.5}; |
There was a problem hiding this comment.
nit: space after the equal sign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts components created/used exclusively in storybook files to ES6.
Also deduplicates the
ExampleDialogButtoncomponent we use in a few of our stories. This actually results in more overall code, but I think where it gets more verbose it actually expresses expected usage of the component being rendered in the story better (instead of passing the component's props intoExampleDialogButtonand assuming the reader knows they are passed through).It's probably helpful to either view this diff without whitespace (
?w=1) or view the last couple of commits on their own.