Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level group cleanup #18422

Merged
merged 2 commits into from Oct 17, 2017
Merged

Level group cleanup #18422

merged 2 commits into from Oct 17, 2017

Conversation

Bjvanminnen
Copy link
Contributor

@Bjvanminnen Bjvanminnen commented Oct 17, 2017

Restores PR with a fix to ensure that our page number is an integer (rather than a string). Validated that the UI tests that had been failing no longer are (locally).

Original PR being restored: #18316
Revert PR #18338

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 What a pain. We even went in circles a little on this the first time around. Integration points are hard. 😁

@Bjvanminnen Bjvanminnen merged commit 64c5e82 into staging Oct 17, 2017
@Bjvanminnen Bjvanminnen deleted the levelGroupCleanup branch October 17, 2017 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants