Don't use first_or_create to merge seed data with existing dataset #18431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeding calls
find_or_create_all_from_tsv
which was executingSchoolDistrict.where(attributes).first_or_create!
on the model. This doesn't support the case where existing data has changed. For instance, a school district entry in the TSV file where the city name has changed.I created a new method for #18396 which merges the results. This change forwards the
find_or_create_all_from_tsv
call to the newmerge_from_csv
.