Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "lazy-loading locale I18n backend" #18447

Merged
merged 1 commit into from Oct 17, 2017
Merged

Conversation

wjordan
Copy link
Contributor

@wjordan wjordan commented Oct 17, 2017

Reverts #18315.

Failing UI tests with i18n-test errors:

[i18n]
[i18n] expected: "Ok, this is just like the last puzzle, but you need to remember how you used the \"if\" block and the \"repeat\" block together."
[i18n]      got: "Vale, esto es como el último rompecabezas, pero tienes que recordar cómo usaste el bloque \"si\" y el bloque \"repetir\" juntos."
[i18n]
[i18n] (compared using ==)
[i18n]  (RSpec::Expectations::ExpectationNotMetError)
[i18n] ./features/support/browser_helpers.rb:18:in `element_has_i18n_text'
[i18n] ./features/step_definitions/steps.rb:562:in `/^element "([^"]*)" has "([^"]*)" text from key "((?:[^"\]|\.)*)"$/'
[i18n] ./features/support/hooks.rb:45:in `call'
[i18n] ./features/support/hooks.rb:45:in `block in <top (required)>'
[i18n] features/i18n.feature:8:in `Then element ".csf-top-instructions p" has "es" text from key "data.level.instructions.maze_2_14"'

@wjordan wjordan merged commit eb8130b into staging Oct 17, 2017
@wjordan wjordan deleted the revert-18315-lazy-locales branch October 17, 2017 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant