Change count columns to nullable in school_stats_by_years #18477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopolsky
changed the title
jopolsky
force-pushed
the
change-count-columns-to-null-in-school-stats
branch
from
e05075d
to
6fb1359
Compare
jopolsky
force-pushed
the
change-count-columns-to-null-in-school-stats
branch
from
6fb1359
to
9f25b73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data for these columns are in separate data files which may not contain data for all school entries, and those specific data files are not always available year over year, in this case a more appropriate value would be
nullrather than0. Also, in some cases the data in the schools directory file is set to-1, a more appropriate value here might also benull.Related to: #17791