More homepages es6 updates #18480
Merged
More homepages es6 updates #18480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
reviewed
Oct 18, 2017
| @@ -48,8 +48,8 @@ const styles = { | |||
| } | |||
| }; | |||
|
|
|||
| const SetUpMessage = React.createClass({ | |||
| propTypes: { | |||
| export default Radium(class SetUpMessage extends Component { | |||
There was a problem hiding this comment.
I think this is the only component in this PR that doesn't have its own test coverage. Up for a quick unit test?
There was a problem hiding this comment.
We have coverage on uses of SetUpMessage in https://github.com/code-dot-org/code-dot-org/blob/staging/apps/test/unit/templates/studioHomepages/SetUpCoursesTest.jsx and https://github.com/code-dot-org/code-dot-org/blob/staging/apps/test/unit/templates/studioHomepages/SetUpSectionsTest.jsx. Is that sufficient?
There was a problem hiding this comment.
Yeah, that's great! I should have waited for the coverage report to be generated. 😁
islemaster
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to new syntax for
StudentHomepage,RecentCoursesandSetUpMessage.