Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sending email when somebody completes the hoc census form #18499

Merged
merged 1 commit into from
Oct 19, 2017

Conversation

drewsamnick
Copy link
Contributor

We are currently sending an email when somebody signs up for HOC and then a second email after they complete the census form. We don't want to send two emails so this will disable the census one.

@@ -28,6 +28,6 @@ def self.normalize(data)
end

def self.receipt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even this self.receipt method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to override the method on the parent (HocSignup2017)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@drewsamnick
Copy link
Contributor Author

@drewsamnick drewsamnick merged commit 435ecfc into staging Oct 19, 2017
@drewsamnick drewsamnick deleted the hoc-no-census-email branch October 19, 2017 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants