React: More components from templates/progress #18518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjvanminnen
reviewed
Oct 20, 2017
| }), | ||
| {setIsSummaryView} | ||
| )(class ProgressDetailToggle extends React.Component { | ||
| static propTypes = { |
There was a problem hiding this comment.
I would rather have the connect separate from the class TBH (i.e. at the end of the file). The syntax here seems kind of difficult to read. The pattern of having them separate also makes it easy to export a non-connected version as well as a connected version.
Bjvanminnen
approved these changes
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four more components. These all have good storybook coverage.