Re-factor: Reacttabular styles and table actions #18526
Conversation
|
cc werketing @breville @tanyaparker @Erin007 |
caleybrock
requested review from
islemaster,
Erin007 and
Bjvanminnen
and removed request for
islemaster
|
Switching Brad out for Brent as reviewer since Brad has a presentation tomorrow. |
|
What happens when any of these tables are RTL? |
| import color from "../../util/color"; | ||
| import styleConstants from "../../styleConstants"; | ||
|
|
||
| // Constants for React tables |
There was a problem hiding this comment.
It seems like this entire file is generally stuff for reacttabular tables. I wonder if we should rename it to reflect that, i.e. reactabularStyles.js or reactabularConstants.js?
There was a problem hiding this comment.
Although I didn't do this, I think html tables could be setup to work with these styles, so I purposefully kept it general.
|
@Erin007 Good question. The styles on these are all the same as before, so RTL is the same as it currently looks. That being said I imagine there are some improvements we could make there, because it doesn't look like any of them have specific support. |
This PR does:
ManageStudentsTable,PersonalProjectsTable, andSectionTableuse the common stylesQuickActionsto a common table location so other tables that need actions can use it (todo: add toManageStudentsTable)This PR does NOT:
SectionsTable(not to be confused withSectionTable), which does not use react-tabular, but still has a set of table stylesWhat's next?
QuickActionsmore re-usable by also creating a common child componentSectionsTableto use react-tabular/tableConstants to keep it consistent with the rest of our tablesProjectListwith the new styles, since it already uses react-tabular, but has angular styles. Mark said to hold off on this one until getting specific instruction, but this would be a very simple work item nowScreenshots:
ManageStudentsTable
PersonalProjectsTable
SectionTable
