Migrate sections when taking over account with Clever #18531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
approved these changes
Oct 20, 2017
There was a problem hiding this comment.
o_0 Whoops! Good fix. What else associated with the existing account id are we accidentally leaving behind? Progress info, saved projects, user permissions... seems like we should do a detailed audit of relationships we might need to update when merging users.
|
There won't be much else, because this flow only triggers upon the first sign in for a Clever user. Pretty much the only thing that can be in their account is a connect to sections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where after Clever account takeover, the Clever sections went missing from the account. This resolves that problem by changing the user ID to the taken over account on all relevant Followers.