Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autofocus on new account page #18560

Merged
merged 2 commits into from Oct 23, 2017

Conversation

ewjordan
Copy link
Contributor

At least via the Chrome simulator, works fine on mobile:

screen shot 2017-10-20 at 4 54 11 pm

@breville
Copy link
Member

It would be good to see this on a real iOS device before committing, because they pop a custom selector down the bottom of the screen, and I don't recall ever seeing a page pop that by default. So.. am just curious what the UX is like in that case.

Also on desktop browsers, does the dropdown expand when it has default focus? I wonder if this feels a bit broken if it doesn't.

@ewjordan
Copy link
Contributor Author

No, the dropdown doesn't expand by default, it's just highlighted:

screen shot 2017-10-20 at 5 16 32 pm

We could also just not auto-focus anything, which might make more sense if this doesn't help very much.

@breville
Copy link
Member

An alternative would be to set initial focus to Email field, with assumption that only a small number of visitors will want to switch their account type. @tanyaparker would have opinions here too.

@tanyaparker
Copy link
Contributor

I definitely don't want to switch focus to email. Since account type doesn't default to anything, they should pick that first. If we autofocus to account type and we automatically open the dropdown, I think that's broken/annoying. It should only highlight but not open. My preference:

  1. No autofocus at all
  2. Autofocus account type and don't open dropdown automatically
  3. Autofocus account type and open dropdown automatically

@ewjordan
Copy link
Contributor Author

I guess for now I'll switch to no autofocus at all, unless there are any objections? Always easy to change later if we feel like we need to.

@ewjordan ewjordan changed the title Change autofocus on new account page to user type instead of user name Disable autofocus on new account page Oct 21, 2017
@tanyaparker
Copy link
Contributor

SGTM

@ewjordan ewjordan merged commit 1752668 into staging Oct 23, 2017
@ewjordan ewjordan deleted the change-autofocus-on-new-account-page branch October 23, 2017 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants